Skip to content

Conversation

@ValClarkson
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Other Information:

@ValClarkson ValClarkson requested a review from tjmoore4 October 31, 2025 20:09
@ValClarkson ValClarkson enabled auto-merge (rebase) November 4, 2025 20:23
@ValClarkson ValClarkson disabled auto-merge November 4, 2025 20:24
@cbandy cbandy mentioned this pull request Nov 4, 2025
5 tasks
A recent change caused this tool to select the *oldest* Kubernetes
binaries rather than the newest:

  https://www.github.com/kubernetes-sigs/controller-runtime/issues/3379

This entire tool can be dropped when we move to controller-runtime 0.22.x
which has this feature:

  https://www.github.com/kubernetes-sigs/controller-runtime/pull/3280
@cbandy
Copy link
Member

cbandy commented Nov 6, 2025

📝 rebase should make the checks happy.

dsessler7 and others added 5 commits November 6, 2025 12:09
… postgres_exporter is used with postgres versions greater than 17, create a warning event and set the setup.sql blank.
A recent change caused this tool to select the *oldest* Kubernetes
binaries rather than the newest:

  https://www.github.com/kubernetes-sigs/controller-runtime/issues/3379

This entire tool can be dropped when we move to controller-runtime 0.22.x
which has this feature:

  https://www.github.com/kubernetes-sigs/controller-runtime/pull/3280
… postgres_exporter is used with postgres versions greater than 17, create a warning event and set the setup.sql blank.
@ValClarkson ValClarkson enabled auto-merge (rebase) November 6, 2025 20:28
@ValClarkson ValClarkson disabled auto-merge November 6, 2025 20:34
@ValClarkson ValClarkson closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants