Adds Support for COPY TO/FROM Google Cloud Storage #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
from
2feb683 to
3d026b6
Compare
aykut-bozkurt
force-pushed
the
aykut/google-cloud-storage
branch
from
048bd25 to
4a93f99
Compare
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
2 times, most recently
from
afb3c71 to
2a3061f
Compare
aykut-bozkurt
force-pushed
the
aykut/google-cloud-storage
branch
from
4a93f99 to
c1ba6ad
Compare
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
from
2a3061f to
0a3281f
Compare
aykut-bozkurt
force-pushed
the
aykut/google-cloud-storage
branch
from
c1ba6ad to
5d15466
Compare
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
from
0a3281f to
80e449f
Compare
aykut-bozkurt
force-pushed
the
aykut/google-cloud-storage
branch
2 times, most recently
from
b588cfd to
a61b15d
Compare
Supports following Azure Blob uri forms:
- `az://{container}/key`
- `azure://{container}/key`
- `https://{account}.blob.core.windows.net/{container}`
**Configuration**
The simplest way to configure object storage is by creating the standard [`~/.azure/config`](https://learn.microsoft.com/en-us/cli/azure/azure-cli-configuration?view=azure-cli-latest) file:
```bash
$ cat ~/.azure/config
[storage]
account = devstoreaccount1
key = Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==
```
Alternatively, you can use the following environment variables when starting postgres to configure the Azure Blob Storage client:
- `AZURE_STORAGE_ACCOUNT`: the storage account name of the Azure Blob
- `AZURE_STORAGE_KEY`: the storage key of the Azure Blob
- `AZURE_STORAGE_SAS_TOKEN`: the storage SAS token for the Azure Blob
- `AZURE_CONFIG_FILE`: an alternative location for the config file
**Bonus**
Additionally, PR supports following S3 uri forms:
- `s3://{bucket}/key`
- `s3a://{bucket}/key`
- `https://s3.amazonaws.com/{bucket}/key`
- `https://{bucket}.s3.amazonaws.com/key`
Closes #50
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
from
80e449f to
8553677
Compare
Supports following Google Cloud Storage uri forms:
- gs:// \<bucket\> / \<path\>
**Configuration**
The simplest way to configure object storage is by creating a json config file like [`/tmp/gcs.json`]:
```bash
$ cat /tmp/gcs.json
{
"gcs_base_url": "gs://testbucket/test.parquet",
"disable_oauth": false,
"client_email": "...",
"private_key_id": "...",
"private_key": "..."
}
```
Alternatively, you can use the following environment variables when starting postgres to configure the Google Cloud Storage client:
- `GOOGLE_SERVICE_ACCOUNT_KEY`: json serialized service account key
- `GOOGLE_SERVICE_ACCOUNT_PATH`: an alternative location for the config file
Closes #62
aykut-bozkurt
force-pushed
the
aykut/google-cloud-storage
branch
from
a61b15d to
f187bc4
Compare
aykut-bozkurt
force-pushed
the
aykut/google-cloud-storage
branch
from
0c15989 to
d76bf55
Compare
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
from
24ff523 to
e0df256
Compare
aykut-bozkurt
force-pushed
the
aykut/azure-blob-storage
branch
from
e0df256 to
e9d0cdd
Compare
- get rid of aws-sts dep in test as aws_config already supports it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 92.54% 92.54% -0.01%
==========================================
Files 75 76 +1
Lines 9621 9686 +65
==========================================
+ Hits 8904 8964 +60
- Misses 717 722 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports following Google Cloud Storage uri forms:
Configuration
The simplest way to configure object storage is by creating a json config file like [
/tmp/gcs.json]:$ cat /tmp/gcs.json { "gcs_base_url": "gs://testbucket/test.parquet", "disable_oauth": false, "client_email": "...", "private_key_id": "...", "private_key": "..." }Alternatively, you can use the following environment variables when starting postgres to configure the Google Cloud Storage client:
GOOGLE_SERVICE_ACCOUNT_KEY: json serialized service account keyGOOGLE_SERVICE_ACCOUNT_PATH: an alternative location for the config fileCloses #62