Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flagged describe #432

Closed
wants to merge 1 commit into from
Closed

feat: add flagged describe #432

wants to merge 1 commit into from

Conversation

victormejia
Copy link

Grabbing existing changes from #284 and fixed tests.

kellyselden
kellyselden requested changes Feb 6, 2021
View reviewed changes
Copy link
Collaborator

@kellyselden kellyselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes:

  • you should cherry pick Preston's commit first so authorship is retained.
  • this needs new tests to verify the feature works
  • We should also retain the old createFlaggedTest export name to prevent a breaking change.

@victormejia victormejia closed this Feb 8, 2021
@victormejia victormejia deleted the flagged-describe branch February 8, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyselden kellyselden kellyselden requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victormejia @kellyselden