chore(internal): apply pr feedback on #284

CrowdStrike · Aug 14, 2020 · 2333a91 · 2333a91
1 parent 22ea958
commit 2333a91
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/packages/mocha/src/flag.js b/packages/mocha/src/flag.js
@@ -48,7 +48,7 @@ function isSkipped({ flags, total, isDeactivated }) {
 
 function flaggedIt(total, isDeactivated) {
   return it => {
-    return function flaggedTest(stringOrObject, callback) {
+    return function flaggedIt(stringOrObject, callback) {
       let { name, flags } = infoFor(stringOrObject);
 
       if (!isDeactivated) {
@@ -74,7 +74,7 @@ const mochaAfterEach = global.afterEach;
 
 function flaggedDescribe(total, isDeactivated) {
   return (describe) => {
-    return function _flaggedDescribe(stringOrObjectOrCallback, callback) {
+    return function flaggedDescribe(stringOrObjectOrCallback, callback) {
       let { name, flags } = infoFor(stringOrObjectOrCallback);
 
       if (!isDeactivated) {
@@ -85,7 +85,13 @@ function flaggedDescribe(total, isDeactivated) {
         callback = stringOrObjectOrCallback;
       }
 
-      describe(name, function() {
+      let describeArgs = [];
+
+      if (name) {
+        describeArgs.push(name);
+      }
+
+      function anonymousDescribe() {
         function before(beforeCallback) {
           return mochaBefore(function (...args) {
             if (isSkipped({ flags, total, isDeactivated })) {
@@ -131,7 +137,12 @@ function flaggedDescribe(total, isDeactivated) {
         }
 
         callback.apply(this, [{ beforeEach, afterEach, before, after }]);
-      });
+
+      }
+
+      describeArgs.push(anonymousDescribe);
+
+      describe(...describeArgs);
     };
   };
 }
@@ -153,7 +164,6 @@ function createDescribe(describe, flags, isDeactivated) {
 }
 
 module.exports = {
-  create: createIt,
   createIt: createIt,
   createDescribe,
 };
diff --git a/packages/mocha/src/index.js b/packages/mocha/src/index.js
@@ -84,7 +84,6 @@ module.exports = {
   createRolesHelper: require('./role').create,
   failureArtifacts: require('./failure-artifacts'),
   createFailureArtifactsHelpers: require('./failure-artifacts').create,
-  createFlaggedTest: createFlaggedIt,
   createFlaggedIt: createFlaggedIt,
   createFlaggedDescribe,
 };