fix bash API-download script downloading ARM packages on non-ARM hosts #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ubuntu 18/20 x86_64 the script tried to install the ARM64 package which was the first in the list with the "os_version": "18/20 - arm64"
|
By the way, the installers API should The current way of doing this is a terrible hack. |
|
@joekohlsdorf would you mind adding this to the https://github.com/CrowdStrike/falcon-scripts/blob/main/bash/install/falcon-linux-install.sh script which has a lot more functionality? We'd like to deprecate this script in favor of the new one. |
joekohlsdorf
changed the title
|
I won't add it to the other script because I'm not using it and I don't have any experience using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 18/20 x86_64 the script tried to install the ARM64 package which was the first in the list with the
"os_version": "18/20 - arm64".This change makes the installer compatible with both ARM and non-ARM packages.