🐛 Fix image file clipboard transfer to web applications #2638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the image file clipboard transfer issue for web applications by adding a new fallback branch that maps the URL_FLAVOR to the file's URL.
- Added import and handling for URL_FLAVOR in DesktopImageTypePlugin.kt.
- Added similar handling for URL_FLAVOR in DesktopFilesTypePlugin.kt.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/desktopMain/kotlin/com/crosspaste/paste/plugin/type/DesktopImageTypePlugin.kt | Added URL_FLAVOR branch for image file URL conversion. |
| app/src/desktopMain/kotlin/com/crosspaste/paste/plugin/type/DesktopFilesTypePlugin.kt | Added URL_FLAVOR branch for file URL conversion. |
app/src/desktopMain/kotlin/com/crosspaste/paste/plugin/type/DesktopImageTypePlugin.kt
Outdated
Show resolved
Hide resolved
app/src/desktopMain/kotlin/com/crosspaste/paste/plugin/type/DesktopFilesTypePlugin.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #2637 by ensuring that when exactly one file is selected for copying, its URL is properly transferred to web applications via the URL flavor.
- In DesktopImageTypePlugin, import URL_FLAVOR and add URL mapping when there is a single image file.
- In DesktopFilesTypePlugin, add a similar URL mapping for single file selection.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DesktopImageTypePlugin.kt | Adds URL flavor mapping for a single image file clipboard transfer. |
| DesktopFilesTypePlugin.kt | Adds URL flavor mapping for a single file clipboard transfer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2637