Skip to content

🐛 Fix HTML and RTF pasteboard view rendering issues #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

guiyanakuang
Copy link
Member

close #2591

@guiyanakuang guiyanakuang added this to the CrossPaste 1.1.2 milestone Apr 8, 2025
@guiyanakuang guiyanakuang self-assigned this Apr 8, 2025
@guiyanakuang guiyanakuang requested a review from Copilot April 8, 2025 12:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

app/src/commonMain/kotlin/com/crosspaste/ui/paste/GenerateImageView.kt:70

  • [nitpick] Consider extracting the conditional maxLines logic into a well-named variable (e.g., effectiveMaxLines) to improve readability.
maxLines = if (preview) { 4 } else { Int.MAX_VALUE },

app/src/commonMain/kotlin/com/crosspaste/ui/paste/GenerateImageView.kt:39

  • [nitpick] Since appSize is no longer used due to the switch to fillMaxSize(), consider removing its injection and any related imports to keep the code clean.
val appSize = koinInject<AppSize>()

@guiyanakuang guiyanakuang merged commit ec39b04 into main Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix HTML and RTF pasteboard view rendering issues
1 participant