Dev/reucru01/msvc sve ldst tests fix#3
Closed
CrooseGit wants to merge 3 commits into
Closed
Conversation
This reverts commit ae9cb1c.
CrooseGit
force-pushed
the
dev/reucru01/msvc-sve-ldst-tests-fix
branch
2 times, most recently
from
323a384 to
015a1a2
Compare
The tests were failing as sometimes the FFR was being clobbered between the `svsetffr` and `svrdffr`. When `as_ptr()` is called on the `LazyLock` data for the first time one test thread will initialise it, while the others are blocked and wait. The wait/block is achieved with a syscall which on windows just so happens to sometimes clobber the FFR, as it is free to do as the FFR is caller saved. To fix this, we just ensure that the `as_ptr` is not called between the set and read.
CrooseGit
force-pushed
the
dev/reucru01/msvc-sve-ldst-tests-fix
branch
from
015a1a2 to
710c4c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.