refactor: Clarify collection step with Contraption Actors #9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is a breaking change. Please add a deprecated overload with the old name. |
adaliszk
force-pushed
the
refactor/drill-actor-collection
branch
2 times, most recently
from
dd620a9 to
e41a444
Compare
With the expectation that the various method signatures do describe what they do, the "dropItem" was exceptionally hard to doubt and gone past it several months before come to the conclusion that maybe there are some side effects implemented where the signature may not suggest. This does not do any functional change, but improves the readability as now the five places where this "dropItem" was used, there is a clear indication that the item collection does happen, and suggests that the context needed to be passed not for position only, but for the contraption storage as well.
adaliszk
force-pushed
the
refactor/drill-actor-collection
branch
from
e41a444 to
08882bb
Compare
Collaborator
Author
Done, sorry for the late reaction: 
|
Collaborator
Author
|
Hmm, the game test could not create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the expectation that the various method signatures accurately describe their functions, the "dropItem" was exceptionally hard to doubt and had been considered for several months before concluding that perhaps some side effects were implemented that the signature may not suggest.
This does not do any functional change, but improves the readability as now, in the five places where this "dropItem" was used, there is a clear indication that the item collection does happen, and suggests that the context needed to be passed not only for position, but for the contraption storage as well.