Skip to content

Make Basins render their fluid correctly on contraptions #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: mc1.20.1/dev
Choose a base branch
from
Open

Make Basins render their fluid correctly on contraptions #9168

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f7c490
What the hell am i doing
vercte Aug 29, 2025
4fbbd6c
Haha! don't need that anymore
vercte Aug 29, 2025
95d0f9a
its better now !
vercte Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/main/java/com/simibubi/create/content/processing/basin/BasinMovementBehaviour.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,26 @@
package com.simibubi.create.content.processing.basin;

import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import com.simibubi.create.api.behaviour.movement.MovementBehaviour;
import com.simibubi.create.content.contraptions.behaviour.MovementContext;

import com.simibubi.create.content.contraptions.render.ContraptionMatrices;
import com.simibubi.create.foundation.render.BlockEntityRenderHelper;
import com.simibubi.create.foundation.virtualWorld.VirtualRenderWorld;

import net.minecraft.client.renderer.MultiBufferSource;
import net.minecraft.core.Direction;
import net.minecraft.world.entity.item.ItemEntity;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.phys.Vec3;

import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.api.distmarker.OnlyIn;
import net.minecraftforge.items.ItemStackHandler;

public class BasinMovementBehaviour implements MovementBehaviour {
Expand Down Expand Up @@ -53,4 +62,24 @@ private void dump(MovementContext context, Vec3 facingVec) {
((BasinBlockEntity) blockEntity).readOnlyItems(context.blockEntityData);
context.temporaryData = false; // did already dump, so can't any more
}

@Override
@OnlyIn(Dist.CLIENT)
public void renderInContraption(MovementContext context, VirtualRenderWorld renderWorld, ContraptionMatrices matrices, MultiBufferSource buffer) {
BasinBlockEntity basin = null;

Collection<BlockEntity> bes = context.contraption.getRenderedBEs();
for (BlockEntity blockEntity: bes) {
if (blockEntity instanceof BasinBlockEntity basinBlockEntity) {
if (basinBlockEntity.getBlockPos().equals(context.localPos)) basin = basinBlockEntity;
}
}

if (basin != null) {
basin.read(context.blockEntityData, true);
basin.tick();
BlockEntityRenderHelper.renderBlockEntities(context.world, renderWorld, List.of(basin),
matrices.getModelViewProjection(), matrices.getLight(), buffer);
}
}
}