Fix unloaded postbox voiding packages #8553
Merged
+84
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an area of chunks where `Level.isLoaded` returns `false`, but `PostboxBlockEntity.onChunkUnloaded` has not yet been called. Any trains delivering to that area will use the offline buffer, but when the block entity is eventually unloaded, it will overwrite the delivered packages with an older version of the inventory, causing them to be lost. I made the following changes to fix this: - Sync the offline buffer whenever the inventory changes, rather than in `onChunkUnloaded`. - Fix `StationBlockEntity.attachPackagePort` incorrectly replacing `GlobalPackagePort` instances with new ones, resetting their data. - During mail transfer, get the `Level` from `ServerLifecycleHooks` rather than `CarriageContraptionEntity`: this ensures a loaded postbox will always be discovered, regardless of whether the train itself is loaded. Fixes Creators-of-Create#7491
|
Does your pr fix #8260 ? |
|
Will this pull request be merged? The issue makes the mod too unstable for using packages in survival mode. |
It sounds like in your case, the train is not loaded while the postbox is. If that was cause of the duplication then it should hopefully be fixed by the 3rd change in this PR. I've not tested this. |
|
Thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
Creators-of-Create:mc1.20.1/dev
with commit Sep 16, 2025
07a4fee
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an area of chunks where
Level.isLoadedreturnsfalse, butPostboxBlockEntity.onChunkUnloadedhas not yet been called. Any trains delivering to that area will use the offline buffer, but when the block entity is eventually unloaded, it will overwrite the delivered packages with an older version of the inventory, causing them to be lost.I made the following changes to fix this:
onChunkUnloaded.StationBlockEntity.attachPackagePortincorrectly replacingGlobalPackagePortinstances with new ones, resetting their data.LevelfromServerLifecycleHooksrather thanCarriageContraptionEntity: this ensures a loaded postbox will always be discovered, regardless of whether the train itself is loaded.Fixes #7491 (see my comment there for how to reproduce the bug)