Skip to content

fix(opencode): create root span per prompt for OTEL trace isolation#31

Merged
CreatorGhost merged 2 commits into
devfrom
otel-root-span
Jul 12, 2026
Merged

fix(opencode): create root span per prompt for OTEL trace isolation#31
CreatorGhost merged 2 commits into
devfrom
otel-root-span

Conversation

@CreatorGhost

Copy link
Copy Markdown
Owner

Port of upstream anomalyco/opencode#36179. Each prompt now runs under its own OTEL root span instead of inheriting ambient trace context, isolating traces per prompt. Verified: typecheck clean in packages/opencode.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@CreatorGhost, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f824349-8f18-4ba2-ad9c-ca3ac92b4912

📥 Commits

Reviewing files that changed from the base of the PR and between 8db326a and feecef4.

📒 Files selected for processing (1)
  • packages/opencode/src/session/prompt.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch otel-root-span

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Addresses Opus review of PR #31: the root span wrapped the ensureRunning caller,
but ensureRunning may store work and start it later from a prior run's fiber, so
queued/steered prompts got child spans mis-parented under the previous prompt's
trace and the span measured queue-wait instead of the agent turn. Wrap runLoop
(the forked work) instead, and keep the named SessionPrompt.loop fn.
@CreatorGhost CreatorGhost merged commit d47c3b7 into dev Jul 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant