Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- CASMPET-7180: New CFS play for enabling spire for SBPS Marshal Agent #296

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ravikanth-nalla-hpe
Copy link
Contributor

@ravikanth-nalla-hpe ravikanth-nalla-hpe commented Aug 23, 2024

- CASMPET-7180: New CFS play for enabling spire for SBPS Marshal Agent
- CASMPET-7195: New CFS play for install (+ previous enable) SBPS Marshal Agent
- typo fix in DNS SRV A records creation
- updated CHANGELOG.md

Summary and Scope

Part of the iSCSI SBPS feature:

  • Added new CFS play for enabling spire for SBPS Marshal Agent
  • Added new CFS play for installing SBPS Marshal Agent (+ previous SBPS Marshal Agent enable/ start)
  • Fixed typo in DVS SRV and A records creation

Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

  • Resolves [issue id](issue link)
  • Change will also be needed in <insert branch name here>
  • Future work required by [issue id](issue link)
  • Documentation changes required in [issue id](issue link)
  • Merge with/before/after <insert PR URL here>

Testing

Worker node personalization (for iSCSI SBPS) with CFS Ansible plays.

Tested on:

Bare metal system: surtur

Test description:

  • verified that spire is enabled as appropriate.

  • verified that the SBPS Marshal agent gets installed from CSM noos distribution and enables as appropriate.

  • verified DNS SRV A records are created as appropriate without any fail.

  • ran CFS plays for verifying the overall personalization of worker nodes w.r.t iSCSI SBPS and see that iSCSI LUNs with mapped to images are discovered/ mapped.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?

  • Were continuous integration tests run? If not, why?

  • Was upgrade tested? If not, why?

  • Was downgrade tested? If not, why?

  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

None

Pull Request Checklist

  • [NA] Version number(s) incremented, if applicable
  • Copyrights updated
  • [ NA] License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • [NA ] HPC Product Announcement prepared, if applicable

- CASMPET-7195: New CFS play for install (+ previous enable) SBPS Marshal Agent
- typo fix in DNS SRV A records creation
- updated CHANGELOG.md
@@ -23,7 +23,7 @@
#
# Tasks for the csm.gpg_keys role
- name: Fetch Public GPG Keys from the K8S secret
no_log: true
# no_log: true
Copy link
Contributor

@mharding-hpe mharding-hpe Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not check in commented lines of code -- just remove them if they are no longer needed.

But in this case, I think it is correct for it to be no_log, for security reasons.

Suggested change
# no_log: true
no_log: true

@mharding-hpe mharding-hpe merged commit f17ebbf into develop Aug 23, 2024
4 of 5 checks passed
@mharding-hpe mharding-hpe deleted the feature/CASMPET-7180-7195 branch August 23, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants