CASMINST-6896: Support multiple GPG signing keys and install them #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
changed the title
rustydb
approved these changes
Jun 26, 2024
6 tasks
mharding-hpe
requested changes
Jun 26, 2024
There was a problem hiding this comment.
I'm marking this as "requesting changes" to make sure that this doesn't merge until @mtupitsyn 's concern has been addressed.
5 tasks
mtupitsyn
approved these changes
Jun 26, 2024
mharding-hpe
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Add multiple GPG keys via CFS
Most of this code was written by @mtupitsyn, I just borrowed it.
Issues and Related PRs
Testing
node-personalization and image customization were both successful
Tested on:
Risks and Mitigations
none known
Pull Request Checklist