Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

68 sweden data retrieval #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kriszieba
Copy link

#########

IMPORTANT NOTICE

Before opening the Pull Request make sure that you:

  • Have read the CONTRIBUTING GUIDE
  • Have read the DATA MODEL and DATA SOURCES documentation.
  • Have check that your code is compliant with both.
  • Delete this notice, failing to do so will result in this PR being closed without prior review.

#########

Description

Added first vesion of data retrieval module. The module is sourced by data from another project's GitHub repo (due to difficulties of getting primary data). Despite isolated testing of the module, the module was not tested as a part of geo_task.

HELP NEEDED: I'd appreciate contribution in making init, main, .json, audit files and overall integration with the task_geo.

Fixes # (issue)

Checklist:

  • I have read the CONTRIBUTING GUIDE and made sure this Pull Request is compliant with it.
  • I have read the DATA MODEL and DATA SOURCES and made sure this Pull Request is compliant with it.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hyberson
Copy link

hyberson commented May 3, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants