[#51] 쿠폰 조회 API 연결 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JitHoon
requested review from
turkey-kim,
JitHoon,
jiohjung98,
dabin-Hailey and
ovoxiix
JitHoon
approved these changes
Jan 21, 2024
src/recoil/atoms/couponListState.ts
Outdated
Comment on lines
1
to
2
| import { CouponLitResponse } from '@/types/couponList'; | ||
| import { atom } from 'recoil'; |
There was a problem hiding this comment.
아래 컨벤션으로 통일하면 좋을 것 같습니다!
import { atom } from 'recoil';
import { CouponLitResponse } from '@/types/couponList';
src/types/couponList.ts
Outdated
| @@ -10,43 +10,48 @@ export interface CategoryTabStyleProps { | |||
| $categoryTab: boolean; | |||
| } | |||
|
|
|||
| // api 데이터 타입 | |||
| // api 쿠폰 리스트정보 응답 데이터 | |||
| export interface CouponLitResponse { | |||
There was a problem hiding this comment.
CouponLitResponse 오타인 것 같습니다!
CouponListResponse
Comment on lines
+5
to
+8
| accommodationId: number, | ||
| date?: string, | ||
| status?: string, | ||
| title?: string |
There was a problem hiding this comment.
타입을 분리하면 좋을 것 같습니다!
export interface GetCouponListProps {
accommodationId: number;
date?: string;
status?: string;
title?: string;
}There was a problem hiding this comment.
분리하였습니다!! 감사합니다 !
src/api/lib/getCouponList.ts
Outdated
Comment on lines
10
to
14
| const params = { | ||
| date: date, | ||
| status: status, | ||
| title: title | ||
| }; |
There was a problem hiding this comment.
아래와 같이 작성해도 동작에 무리없을 것 같습니다!
객체의 key 와 value 값이 같다면, property shorthand
const params = {
data,
status,
title
}
src/api/lib/getCouponList.ts
Outdated
Comment on lines
16
to
19
| const result = await instance.get(`/v1/coupons/${accommodationId}`, { | ||
| params | ||
| }); | ||
| return result.data; |
There was a problem hiding this comment.
다빈님이 api를 받아오는 변수로 response를 사용하셨는데, 변수명을 response로 통일하는 건 어떠신가요?
const response = await instance.get(`/v1/coupons/${accommodationId}`, {
params
});
return response.data;
}There was a problem hiding this comment.
넵 좋은 것 같습니다 수정했습니다!
jiohjung98
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #51
Description
유의할 점 및 ETC (Optional)
스크린샷 (Optional)
2024-01-21.12.39.24.mov
전체 카테고리
노출 ON
노출 OFF
만료
검색
(객실리스트)
