[#12] 정산페이지 레이아웃 작업 및 더미 데이터를 사용한 기능 구현 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinjoo-jung
approved these changes
Jan 21, 2024
turkey-kim
approved these changes
Jan 21, 2024
Comment on lines
+102
to
+109
| @media (max-width: 900px) { | ||
| margin: 10px 20px; | ||
|
|
||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| } | ||
| `; |
There was a problem hiding this comment.
미디어 쿼리 쓰는 부분 현재 theme파일 들어가면, 상수화되어 있는데 사용하시는게 좋을 것 같습니다!
추후 변경될 수 있는 너비라 생각해서 다음 PR에서라도 반영되면 좋을 것 같아요!
There was a problem hiding this comment.
앗 넵 알겠습니다 다음 pr에서는 반영해놓겠습니다 !
Comment on lines
+187
to
+189
| @media (max-width: 500px) { | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
이런 (500px) 부분도, 지훈님이 설정해주신 theme파일 지오님 영역에서 상수화해서 관리하면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12
Description
추가된 라이브러리는 다음과 같습니다.
유의할 점 및 ETC (Optional)
스크린샷 (Optional)
-.Clipchamp.mp4