[#43] 로그인 성공 시 쿠키 저장 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dabin-Hailey
requested review from
turkey-kim,
jinjoo-jung,
JitHoon,
jiohjung98 and
ovoxiix
turkey-kim
reviewed
Jan 17, 2024
Comment on lines
+22
to
+28
| export const getCookies: GetCookies = name => { | ||
| const cookieValue = document.cookie | ||
| .split('; ') | ||
| .find(row => row.startsWith(`${name}=`)) | ||
| ?.split('=')[1]; | ||
| return cookieValue; | ||
| }; |
There was a problem hiding this comment.
accessToken을 가져오기 위해서는 원하는 곳에서
getCookies('accessToken')';
이런 식으로 반환받으면 될까요?
turkey-kim
approved these changes
Jan 17, 2024
jinjoo-jung
approved these changes
Jan 18, 2024
JitHoon
approved these changes
Jan 18, 2024
| @@ -22,3 +22,5 @@ dist-ssr | |||
| *.njsproj | |||
| *.sln | |||
| *.sw? | |||
|
|
|||
| .env | |||
There was a problem hiding this comment.
파일 마지막은 항상 개행 부탁드립니다!
https://blog.coderifleman.com/2015/04/04/text-files-end-with-a-newline/
Comment on lines
+10
to
+20
| try { | ||
| document.cookie = `userName=${userName};max-age=${expiresIn};path=/;secure`; | ||
| document.cookie = `userEmail=${userEmail};max-age=${expiresIn};path=/;secure`; | ||
| document.cookie = `accessToken=${accessToken};max-age=${expiresIn};path=/;secure`; | ||
| document.cookie = `refreshToken=${refreshToken};max-age=${expiresIn};path=/;secure`; | ||
| console.log('쿠키설정 성공'); | ||
| } catch (error) { | ||
| console.log(error); | ||
| alert('쿠키설정에 실패했습니다.'); | ||
| } | ||
| }; |
There was a problem hiding this comment.
이 부분 merge 이후에 error boundary 호출할 수 있게 테스트 겸 제가 변경해도 될까요?
jiohjung98
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #43
Description
로그인 성공 시 setCookies로 사용자 정보 (이름, 이메일, 토큰 등)을 쿠키에 저장하고
getCookies를 통해 필요한 곳에서 사용자 정보를 불러와 사용할 수 있습니다.
유의할 점 및 ETC (Optional)
axios 설치했기 때문에, pull받으신 후
npm ci한 번 씩 부탁드립니다!.env 파일 생성하였습니다.
.gitignore과 같은 위치에 파일 생성하여 아래 내용 복붙해주시면 됩니다!