[#21] 헤더 유저 프로필 클릭 시 모달 생성 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JitHoon
requested review from
turkey-kim,
jinjoo-jung,
jiohjung98,
dabin-Hailey and
ovoxiix
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
turkey-kim
approved these changes
Jan 16, 2024
dabin-Hailey
approved these changes
Jan 16, 2024
| <UserIcon | ||
| src={user} | ||
| alt="사용자 프로필" | ||
| onClick={() => setIsUserModalOpen(prev => !prev)} |
There was a problem hiding this comment.
매개변수가 없으니 handleModalOpen 등의 이름으로 함수로 만들신 후에 onClick={}에 함수명만 넣으셔도 좋을 것같습니다!
There was a problem hiding this comment.
동작이 setIsUserModalOpen 이전 불리안 값 반전만 있어서, 이런 경우 함수명을 추가로 지정하여 사용하지 않고 작성해 왔습니다...!
다른 예시
혹시 따로 함수를 빼서 사용해야하는 이유가 있는지 궁금합니다!
jiohjung98
approved these changes
Jan 17, 2024
| @@ -31,6 +29,10 @@ const Header = () => { | |||
| export default Header; | |||
|
|
|||
| const Container = styled.header` | |||
There was a problem hiding this comment.
고생많으셨습니다 ~ 해당 코드 받아서 사용하니까 헤더 고정 잘 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #21
Description
아래 영상을 확인해 주세요!
스크린샷 (Optional)
2024-01-16.6.23.33.mov