Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#134] 등록 페이지 QA 수정사항 반영 #141

Merged
merged 8 commits into from
Jan 29, 2024
Merged

[#134] 등록 페이지 QA 수정사항 반영 #141

merged 8 commits into from
Jan 29, 2024

Conversation

ovoxiix
Copy link
Collaborator

@ovoxiix ovoxiix commented Jan 27, 2024

close #134

Description

  • 최대 할인 금액 / 2박 이상 적용 체크박스 아이콘 수정
  • 선택 객실 모달 체크박스, 닫기 아이콘 수정
  • 아코디언 토글 아이콘 수정
  • 쿠폰 할인 설정 유효성 메시지 수정
  • 미리보기 선택 객실 단어 수정

@ovoxiix ovoxiix added modify 버그 외 사소한 수정 fix 버그 수정 labels Jan 27, 2024
@ovoxiix ovoxiix self-assigned this Jan 27, 2024
Copy link

vercel bot commented Jan 27, 2024

Deployment failed with the following error:

Resource is limited - try again in 47 seconds (more than 100, code: "api-deployments-free-per-day").

Copy link

vercel bot commented Jan 27, 2024

Deployment failed with the following error:

Resource is limited - try again in 12 hours (more than 100, code: "api-deployments-free-per-day").

Copy link
Collaborator

@dabin-Hailey dabin-Hailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~!

setPreview({ ...preview, toAllRooms: e.target.value });
setPreview({
...preview,
toAllRooms: e.target.value === 'true' ? '모든 객실' : '일부 객실'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toAllRooms: !!e.target.value ? '모든 객실' : '일부 객실'

부정 연산자(!)를 사용하면 === true를 작성하지 않고도 boolean 값에 따라 판별할 수 있을 것같습니다!

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cool-peace ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 5:37am
cool-peace-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 5:37am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 modify 버그 외 사소한 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 등록 페이지 QA 수정사항 반영
4 participants