Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spells tracker (current / next achievement) #1023

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

VeteraNovis
Copy link

Modifiy the spellsSection of the statistics page to include a line that
tracks the total spells cast, and the number till the next achievement.

Modifiy the spellsSection of the statistics page to include a line that
tracks the total spells cast, and the number till the next achievement.
@DanielNoord
Copy link
Collaborator

Sorry for taking so long to review this.

Just one comment: how does this work when the Grimoire isn't loaded yet? For example on new saves the Grimoire isn't loaded and the div therefore probably won't be found?

@VeteraNovis
Copy link
Author

@DanielNoord Ah, yep that's definitely something I overlooked. I would have to mark it as 0 until the grimoire is unlocked, as it makes sense that no spells could be cast until that point.

@DanielNoord
Copy link
Collaborator

@VeteraNovis Can we make it so that it doesn't display at all when the Grimoire isn't unlocked? We will also need to handle the failure of the div lookup gracefully.

@VeteraNovis
Copy link
Author

Sounds like a good idea. I'll put some more time into it and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants