Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reduce blobs lookup min wait time to 0 (#8864)" and "Deprecate TTFB, RESP_TIMEOUT, ... (#8839)" #8911

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 11, 2024

This reverts commit 809ea98.
reverts also d633566 because we don't want to release that.

too many RPC requests due to this change (block and blobs)
(last column is the amount of requests in a 12h timeframe. canary is old, holesky-01 is new)
image

I'll put a PR to improve the logic.

related to #8796

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr changed the title Revert "Reduce blobs lookup min wait time to 0 (#8864)" Revert "Reduce blobs lookup min wait time to 0 (#8864)" and "Deprecate TTFB, RESP_TIMEOUT, ..." Dec 11, 2024
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr changed the title Revert "Reduce blobs lookup min wait time to 0 (#8864)" and "Deprecate TTFB, RESP_TIMEOUT, ..." Revert "Reduce blobs lookup min wait time to 0 (#8864)" and "Deprecate TTFB, RESP_TIMEOUT, ... (#8839)" Dec 11, 2024
@tbenr tbenr enabled auto-merge (squash) December 11, 2024 12:20
@tbenr tbenr merged commit 6115f18 into Consensys:master Dec 11, 2024
17 checks passed
@tbenr tbenr deleted the revert-min-wait-to-0 branch December 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants