Finalized transitioned anchor #8850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
… the state transitioned scenario Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
# Conflicts: # CHANGELOG.md # beacon/validator/src/test/java/tech/pegasys/teku/validator/coordinator/DepositProviderTest.java
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
… state Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
rolfyone
reviewed
Dec 2, 2024
| private static final byte[] SEED = new byte[] {0x11, 0x03, 0x04}; | ||
|
|
||
| @Test | ||
| @SuppressWarnings("DoNotCreateSecureRandomDirectly") |
There was a problem hiding this comment.
we are probably better off using DataStructureUtil to get random objects rather than referencing rnd unless there's a really good reason?
rolfyone
reviewed
Dec 2, 2024
| @@ -88,6 +88,7 @@ public SafeFuture<Optional<BeaconState>> getStateToValidate( | |||
| // If the attestation is within the lookahead period for the finalized state, use that | |||
| // If the target block doesn't descend from finalized the attestation is invalid | |||
| final BeaconState finalizedState = recentChainData.getStore().getLatestFinalized().getState(); | |||
| // TODO: Test | |||
rolfyone
reviewed
Dec 2, 2024
| chainUpdater2.initializeGenesis(false); | ||
| chainUpdater2.updateBestBlock(chainUpdater2.advanceChain(11)); | ||
|
|
||
| // chainUpdater2.updateBestBlock(chainUpdater.advanceChain(11)); |
rolfyone
reviewed
Dec 2, 2024
Comment on lines
332
to
333
| public void warnFailedToLoadInitialState(final Throwable throwable) { | ||
| log.warn("Failed to load initial state", throwable); |
There was a problem hiding this comment.
we don't really want the stack trace if we can avoid it, do we jsut want the throwable.getMessage?
rolfyone
reviewed
Dec 2, 2024
| STATUS_LOG.warnFailedToLoadInitialState(e.getMessage()); | ||
| STATUS_LOG.warnFailedToLoadInitialState(ex); |
There was a problem hiding this comment.
would prefer no stacktrace on status log...
There was a problem hiding this comment.
I've changed the method to only print the log the message but the param we're passing could remain the throwable I think
rolfyone
reviewed
Dec 2, 2024
| @@ -466,6 +468,7 @@ public Checkpoint getFinalizedCheckpoint() { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Test me | |||
rolfyone
reviewed
Dec 2, 2024
| // blockRoot should be from last non-empty block | ||
| assertThat(recentChainData.getChainHead().map(MinimalBeaconBlockSummary::getRoot)) | ||
| .contains(anchorPoint.getRoot()); | ||
| // head should be |
There was a problem hiding this comment.
expand comments to be readable or remove...
Signed-off-by: Gabriel Fukushima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR based on top of with some extra test coverage for the changes made in RecentChain and AttestationStateSelector
Fixed Issue(s)
Fixes #7956
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog