Fix missing Gossip subnet subscription on startup #8730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
GossipForkManager
has two different sources ofisHeadOptimistic
flag:RecentChainData.isChainHeadOptimistic()
when starting uponOptimisticHeadChanged()
to update the flagThere are possible cases (e.g. Nashatyrev#166) when the value differs in those two sources. Thus subnet subscriptions (which are to be activated when
isHeadOptimistic
becomesfalse
) may not be activated.This PR initializes the flag with
RecentChainData.isChainHeadOptimistic()
value and then relies ononOptimisticHeadChanged()
notifications onlyFixed Issue(s)
Fix Nashatyrev#166
Documentation
doc-change-required
label to this PR if updates are required.Changelog