Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8525 beacon states cleanup #8725

Merged
merged 3 commits into from
Oct 16, 2024
Merged

8525 beacon states cleanup #8725

merged 3 commits into from
Oct 16, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Oct 14, 2024 •
edited
Loading

PR Description

Clean up the finalized states after switching from ARCHIVE to MINIMAL or PRUNE mode.

Fixed Issue(s)

fixes #8525

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

rolfyone
rolfyone approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'll recover slowly this way but im not sure if we want to configure it to clean up more aggressively.... we'd easily be able to delete 1 state per minute for example, which would be x5 faster that this.

@mehdi-aouadi
Copy link
Contributor Author

LGTM. It'll recover slowly this way but im not sure if we want to configure it to clean up more aggressively.... we'd easily be able to delete 1 state per minute for example, which would be x5 faster that this.

We have the --Xdata-storage-state-pruning-limit and the --Xdata-storage-state-pruning-interval if we want to make it more agressive...

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) October 16, 2024 07:36
@mehdi-aouadi mehdi-aouadi merged commit 2985a96 into Consensys:master Oct 16, 2024
17 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 8525-beacon-states-cleanup branch October 16, 2024 08:03
@rolfyone
Copy link
Contributor

We have the --Xdata-storage-state-pruning-limit and the --Xdata-storage-state-pruning-interval if we want to make it more agressive...

sure, but would you expect to need to set either of those options when you're just changing to minimal or prune mode ?

@mehdi-aouadi
Copy link
Contributor Author

mehdi-aouadi commented Oct 16, 2024 •
edited
Loading

We have the --Xdata-storage-state-pruning-limit and the --Xdata-storage-state-pruning-interval if we want to make it more agressive...

sure, but would you expect to need to set either of those options when you're just changing to minimal or prune mode ?

Definitely not obvious. We can configure the pruner to delete 1 state per minute (if none of the --Xdata-storage-state-pruning-limit and --Xdata-storage-state-pruning-interval is set) when switching the storage mode as you suggested then, wdyt?
Here's a PR #8734

@mehdi-aouadi mehdi-aouadi mentioned this pull request Oct 16, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up old BeaconStates.
2 participants
@mehdi-aouadi @rolfyone