-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8525 beacon states cleanup #8725
8525 beacon states cleanup #8725
Conversation
f087be4
to
9c7d681
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It'll recover slowly this way but im not sure if we want to configure it to clean up more aggressively.... we'd easily be able to delete 1 state per minute for example, which would be x5 faster that this.
9c7d681
to
6d8970c
Compare
We have the |
sure, but would you expect to need to set either of those options when you're just changing to minimal or prune mode ? |
Definitely not obvious. We can configure the pruner to delete 1 state per minute (if none of the |
PR Description
Clean up the finalized states after switching from ARCHIVE to MINIMAL or PRUNE mode.
Fixed Issue(s)
fixes #8525
Documentation
doc-change-required
label to this PR if updates are required.Changelog