Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nightly reference tests #8715

Closed
wants to merge 5 commits into from

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented Oct 11, 2024

PR Description

This is still a work in progress.

  • Create a GitHub access token at https://github.com/settings/tokens with the following perms:
    • repo, workflow, admin:repo_hook (not sure these are actually necessary, but it's what I did)
    • Unfortunately, we need a token to download artifacts programmatically.
    • I would recommend using a burner GitHub account for this just in-case it gets burned.
  • Export this as an environment variable under GITHUB_TOKEN.
    • I just added a export GITHUB_TOKEN="ghp_..." line to my ~/.zshrc file.
  • Run NIGHTLY=true ./gradlew expandRefTests

Next steps:

Add a scheduled CI test that runs at 6am UTC. This is 4 hours after the reference tests are generated. Normally, it takes about 3.5 hours for the test generators to finish.

Notes:

It would have been slightly easier to use gh (GitHub's CLI tool) in a CI test, but I think doing it with Gradle is the better approach for Teku. Easier to maintain and works better with the dev flow.

I tried to convert the NIGHTLY=true environment variable to a --nightly flag, but it was too difficult & not worth it the headache. I defined my own task with an option flag but the problem was calling the task from other tasks.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@jtraglia
Copy link
Contributor Author

Going to break this up into multiple PRs.

@jtraglia jtraglia closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant