feat: implement modulesToCount selection from module limits TOML config #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java
| standardModulesToTrace = initStandardModulesToTrace(); | ||
| modulesToCountMap = initModulesToCountMap(); | ||
|
|
||
| modules = Stream.concat(standardModules.stream(), precompileLimitModules.stream()).toList(); |
There was a problem hiding this comment.
is modules the modules triggered during execution of the evm? If yes, we don't need the precompileLimitModule in, they are now manually triggered by other modules when needed
| l2L1Logs); | ||
| } | ||
|
|
||
| private List<Module> initStandardModulesToTrace() { |
There was a problem hiding this comment.
maybe, the standardModuleToTrace (and to Count) could be initStandardModule + some few others (just take care if some order are needed, like for mum/mmio at tracing time)
| @@ -905,7 +962,7 @@ public final MessageFrame messageFrame() { | |||
| private void handleStack(MessageFrame frame) { | |||
| this.currentFrame() | |||
| .stack() | |||
| .processInstruction(this, frame, MULTIPLIER___STACK_HEIGHT * (stamp() + 1)); | |||
| .processInstruction(this, frame, MULTIPLIER___STACK_HEIGHT * stamp()); | |||
fab-10
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1395
Copied over from Tsvetan's PR#1396
This PR enable the dynamic inclusion/exclusion of modules for the line count RPC response: