Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator use new state manager #237

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team October 23, 2024 18:01
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.92308% with 38 lines in your changes missing coverage. Please review.

Project coverage is 71.00%. Comparing base (807d6c5) to head (f5d35bf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...build/linea/clients/StateManagerV1JsonRpcClient.kt 15.38% 11 Missing ⚠️
...ereum/coordination/blob/BlobZkStateProviderImpl.kt 0.00% 8 Missing ⚠️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 7 Missing ⚠️
...kotlin/build/linea/clients/StateManagerClientV1.kt 0.00% 7 Missing ⚠️
...ea/jsonrpc/client/VertxHttpJsonRpcClientFactory.kt 76.92% 2 Missing and 1 partial ⚠️
...tion/conflation/TracesConflationCoordinatorImpl.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #237      +/-   ##
============================================
+ Coverage     70.54%   71.00%   +0.46%     
  Complexity     1074     1074              
============================================
  Files           300      299       -1     
  Lines         12108    12044      -64     
  Branches       1073     1074       +1     
============================================
+ Hits           8541     8552      +11     
+ Misses         3087     3003      -84     
- Partials        480      489       +9     
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from 807d6c5
kotlin 68.75% <26.92%> (+0.49%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...clients/prover/FileBasedExecutionProverClientV2.kt 59.01% <100.00%> (ø)
...tor/clients/BatchExecutionProverRequestResponse.kt 44.44% <100.00%> (ø)
...dination/conflation/TracesConflationCoordinator.kt 0.00% <ø> (ø)
...face/src/main/kotlin/build/linea/clients/Client.kt 0.00% <ø> (ø)
...tion/conflation/TracesConflationCoordinatorImpl.kt 44.44% <0.00%> (+8.08%) ⬆️
...ea/jsonrpc/client/VertxHttpJsonRpcClientFactory.kt 58.74% <76.92%> (+1.29%) ⬆️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 1.58% <0.00%> (+0.01%) ⬆️
...kotlin/build/linea/clients/StateManagerClientV1.kt 29.41% <0.00%> (+29.41%) ⬆️
...ereum/coordination/blob/BlobZkStateProviderImpl.kt 0.00% <0.00%> (ø)
...build/linea/clients/StateManagerV1JsonRpcClient.kt 78.68% <15.38%> (+78.68%) ⬆️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants