Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] M-01 Validate final blob was submitted on finalization #226

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thedarkjester
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@thedarkjester thedarkjester requested a review from a team as a code owner October 22, 2024 12:37
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (ea017bb) to head (fb92b84).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #226      +/-   ##
============================================
- Coverage     71.18%   71.03%   -0.15%     
+ Complexity     1074     1073       -1     
============================================
  Files           291      291              
  Lines         11965    11967       +2     
  Branches       1050     1103      +53     
============================================
- Hits           8517     8501      -16     
- Misses         2974     2989      +15     
- Partials        474      477       +3     
Flag Coverage Δ
hardhat 98.68% <100.00%> (+<0.01%) ⬆️
kotlin 68.76% <ø> (-0.17%) ⬇️
Files with missing lines Coverage Δ
contracts/contracts/LineaRollup.sol 98.60% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@thedarkjester thedarkjester changed the title [Fix] Validate final blob was submitted on finalization [Fix] M-01 Validate final blob was submitted on finalization Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants