-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prover/Hash Key Consistency #159
Open
arijitdutta67
wants to merge
5
commits into
main
Choose a base branch
from
prover/hkey-consistency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arijitdutta67
assigned arijitdutta67 and AlexandreBelling and unassigned AlexandreBelling and arijitdutta67
Oct 8, 2024
arijitdutta67
requested review from
AlexandreBelling,
Soleimani193 and
bogdanbear
October 8, 2024 07:49
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=========================================
Coverage 70.54% 70.54%
Complexity 1042 1042
=========================================
Files 282 282
Lines 11310 11310
Branches 1028 1080 +52
=========================================
Hits 7979 7979
Misses 2861 2861
Partials 470 470
|
AlexandreBelling
approved these changes
Oct 10, 2024
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
October 11, 2024 10:55
— with
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
October 11, 2024 10:55
— with
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
October 11, 2024 10:55
— with
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
October 11, 2024 10:55
— with
GitHub Actions
Error
bogdanbear
approved these changes
Oct 17, 2024
arijitdutta67
requested a deployment
to
docker-build-and-e2e
October 17, 2024 09:44
— with
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds constraints to verify that the hash keys those are used in the sandwitch check are consistent with that of the corresponding leaf opening values.