feat: forced transaction #798
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: F Bojarski <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: F Bojarski <[email protected]>
| (defcomputedcolumn (PROVER_ILLEGAL_TRANSACTION_DETECTED :binary :bwd) | ||
| (if-not-zero (system-txn-numbers---user-txn-end) | ||
| ;; finalization constraint | ||
| (~ PROVER_ILLEGAL_TRANSACTION_DETECTED_ACC) |
There was a problem hiding this comment.
Bug: Binary Column Receives Invalid Negative Values
The PROVER_ILLEGAL_TRANSACTION_DETECTED binary column uses bitwise NOT (~) on the PROVER_ILLEGAL_TRANSACTION_DETECTED_ACC integer accumulator. This produces -1 when the accumulator is zero and negative values when positive, which are invalid for a binary column expecting 0 or 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Add constraints to flag illegal user transactions using disallowed precompiles and force transaction-end shorthands to binary.
hub/osaka/constraints/forced_transactions.lispwith:illegal-precompilescheck usingPEEK_AT_SCENARIOandscenario/PRC_RIPEMD-160+scenario/PRC_BLAKE2f.PROVER_ILLEGAL_TRANSACTION_DETECTED_ACC(:i16 :fwd) and final flagPROVER_ILLEGAL_TRANSACTION_DETECTED(:binary :bwd) gated byUSERandsystem-txn-numbers---user-txn-end.system-txn-numbers---{sysi,user,sysf}-txn-endand aggregatesystem-txn-numbers---txn-endwithforce-binto ensure binary outputs.Written by Cursor Bugbot for commit 6cebccf. This will update automatically on new commits. Configure here.