Skip to content

refactor: remove dead code and redundant checks #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: remove dead code and redundant checks #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions std/gkrapi/testing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,9 @@ func (api *API) SolveInTestEngine(parentApi frontend.API, options ...SolveInTest

res := make([][]frontend.Variable, len(api.toStore.Circuit))
var verifiedGates sync.Map
for i, w := range api.toStore.Circuit {
for i := range api.toStore.Circuit {
res[i] = make([]frontend.Variable, api.nbInstances())
copy(res[i], api.assignments[i])
if len(w.Inputs) == 0 {
continue
}
}
for instanceI := range api.nbInstances() {
for wireI, w := range api.toStore.Circuit {
Expand Down Expand Up @@ -96,9 +93,6 @@ func (api *API) SolveInTestEngine(parentApi frontend.API, options ...SolveInTest
ins[i] = res[in][instanceI]
}
gate := gkrgates.Get(gkr.GateName(w.Gate))
if gate == nil && !w.IsInput() {
panic(fmt.Errorf("gate %s not found", w.Gate))
}
if _, ok := verifiedGates.Load(w.Gate); !ok {
verifiedGates.Store(w.Gate, struct{}{})

Expand All @@ -110,9 +104,7 @@ func (api *API) SolveInTestEngine(parentApi frontend.API, options ...SolveInTest
panic(fmt.Errorf("gate %s: %w", w.Gate, err))
}
}
if gate != nil {
res[wireI][instanceI] = gate.Evaluate(parentApi, ins...)
}
res[wireI][instanceI] = gate.Evaluate(parentApi, ins...)
}
}
}
Expand Down