Skip to content

sumcheck: convert FinalEvalProof in valueOfProof to emulated types #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sumcheck: convert FinalEvalProof in valueOfProof to emulated types #1624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion std/recursion/sumcheck/proof.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package sumcheck
import (
"github.com/consensys/gnark/std/math/emulated"
"github.com/consensys/gnark/std/math/polynomial"
"math/big"
)

// Proof contains the prover messages in the sumcheck protocol.
Expand Down Expand Up @@ -34,9 +35,36 @@ func valueOfProof[FR emulated.FieldParams](nproof nativeProof) Proof[FR] {
for i := range nproof.RoundPolyEvaluations {
rps[i] = polynomial.ValueOfUnivariate[FR](nproof.RoundPolyEvaluations[i])
}
// TODO: type switch FinalEvalProof when it is not-nil
// Convert native FinalEvalProof into emulated representation when present.
var final EvaluationProof
switch v := any(nproof.FinalEvalProof).(type) {
case nil:
final = nil
case *big.Int:
val := emulated.ValueOf[FR](v)
final = val
case []*big.Int:
vals := make([]emulated.Element[FR], len(v))
for i := range v {
vals[i] = emulated.ValueOf[FR](v[i])
}
final = vals
case [][]*big.Int:
outer := make([][]emulated.Element[FR], len(v))
for i := range v {
inner := make([]emulated.Element[FR], len(v[i]))
for j := range v[i] {
inner[j] = emulated.ValueOf[FR](v[i][j])
}
outer[i] = inner
}
final = outer
default:
panic("sumcheck: unsupported FinalEvalProof type")
}
return Proof[FR]{
RoundPolyEvaluations: rps,
FinalEvalProof: final,
}
}

Expand Down