Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel_architecture adjustments for 2023 #102

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

bartoldeman
Copy link
Contributor

  • Move all wheels with 2023 easybuild rpaths to arch dir
  • Under StdEnv/2023 make all wheels with C extensions gentoo2023 as they can't be shared as purely generic with older StdEnv: they are highly likely to contain illegal instructions for CPUs without AVX2 or BMI2.

As they are compiled with `-march=x86-64-v3` they are highly unlikely
to work on older arches, since even simple code often uses BMI2
instructions. So we cannot typically share them with older
StdEnv as they'll break.
So we know they can't be shared with future StdEnv, unlike
"gentoo2023 generic" wheels.
@ccoulombe ccoulombe marked this pull request as draft October 26, 2023 13:38
@mboisson
Copy link
Member

Hum, it's not because these instructions are present that they are used. By these tests, we probably could never have numpy (or any wheel that does runtime detection) that is considered anything less than the most complete instruction set

@ccoulombe
Copy link
Contributor

These test are to avoid generic generic wheels to be generic when they are really not, and yes runtime detection is a corner case, which meant I needed to review the wheel to validate it does runtime detection and does not have a flag I did not see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants