Warning no version #55
Conversation
|
The relevant commit really is this one: cc36480 |
|
The code looks fine but I have reservations about the digit-based approach. Some packages (e.g. GROMACS) have versions with an inconsistent the number of components/digits (e.g. 2023 and 2023.1 but no 2023.0), others have date-based versions (e.g. LAMMPS 20220623) where “one digit” is a bit unclear (it could be misunderstood to mean “2” rather than “20220623”). I think it would be better to special-case individual packages for which we want a different message. Or, make two lists: packages that follow semantic versioning (e.g. Python, Arrow) and those that do not. Packages that follow semver are the only ones for which I think it is helpful to not use a full version number (and the right number of components/digits for semver-following packages is always 2, major.minor). |
| de ce module pourrait faire échouer vos tâches.]]) | ||
| else | ||
| LmodWarning([[Warning, you have loaded the module ]] .. myModuleName() .. [[ by specifying an incomplete version: "]] .. userProvidedVersion .. [[". | ||
| We strongly recommend that you specify at least ]] .. min_digit .. [[ digits for the version of this module. Not doing this could crash your jobs when we install a newer version in the future.]]) |
There was a problem hiding this comment.
I'd add a word about reproducibility of jobs/submission scripts as it a strong argument along with job crashes.
Something like?
`... Not doing this could crash or make your jobs non-reproducible when we install a newer version in the future.
This pull request is a proposal to address ComputeCanada/software-stack#122