Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable Slurm's spank plugin to manage tmpfs mounts #337

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

mboisson
Copy link
Member

This fixes #336

@cmd-ntrf
Copy link
Member

$enable_tmpfs_mounts is used in profile::slurm::base but defined in profile::slurm::node.

Move $enable_tmpfs_mounts in profile::slurm::base and add a lookup for it in profile::slurm::node. The new parameter will also need to be documented in the README.md.

@cmd-ntrf cmd-ntrf self-requested a review March 13, 2024 14:53
@mboisson
Copy link
Member Author

Fixed.

@mboisson
Copy link
Member Author

mboisson commented Mar 13, 2024

Hum, the PR now fails if

profile::slurm::base::enable_tmpfs_mounts 

is not defined in the hieradata, with

Mar 13 19:22:37 nodegpupool1.int.hackqc-b.calculquebec.cloud puppet-agent[2555]: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Function lookup() did not find a value for the name 'profile::slurm::base::enable_tmpfs_mounts' on node nodegpupool1

@cmd-ntrf cmd-ntrf force-pushed the slurm_disable_spank_tmpfs branch 2 times, most recently from c64fc39 to e5af716 Compare June 10, 2024 18:23
@cmd-ntrf cmd-ntrf force-pushed the slurm_disable_spank_tmpfs branch 2 times, most recently from 6c52f5d to 7bd50ef Compare June 10, 2024 18:32
@cmd-ntrf cmd-ntrf merged commit 4f0e661 into ComputeCanada:main Jun 10, 2024
1 check passed
@mboisson mboisson deleted the slurm_disable_spank_tmpfs branch June 10, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to disable the Slurm spank plugin that manages /tmp
2 participants