Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(mostly) enterprise features #39

Merged
merged 5 commits into from
Dec 4, 2024
Merged

(mostly) enterprise features #39

merged 5 commits into from
Dec 4, 2024

Conversation

Larocceau
Copy link
Contributor

  • Row height setting
  • Supress aggregate in header
  • Row grouping custom rendering

@Larocceau Larocceau force-pushed the hide-aggregate-in-header branch from c4cad3f to 0abd6ea Compare December 4, 2024 16:05
mattgallagher92
mattgallagher92 reviewed Dec 4, 2024
View reviewed changes
src/AgGrid.fs Outdated Show resolved Hide resolved
src/AgGrid.fs Outdated Show resolved Hide resolved
mattgallagher92
mattgallagher92 reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@mattgallagher92 mattgallagher92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that I think it would be good to make, and one of them (RowNode -> node) might be necessary for this code to work.

src/AgGrid.fs Outdated Show resolved Hide resolved
src/AgGrid.fs Outdated Show resolved Hide resolved
@Larocceau Larocceau merged commit 177db60 into main Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgallagher92 mattgallagher92 mattgallagher92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Larocceau @mattgallagher92