Split GitHub workflows out into build and release #30
Conversation
There was a problem hiding this comment.
@jwthomson happy for this to be merged, but some things to consider.
| name: Build | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
I assume that push doesn't include merges? Do we want to build on merge too?
There was a problem hiding this comment.
I can't see an alternative which would seem to include merges. I would have thought that a merge is just a merge commit, which is then pushed, and then the push would trigger this workflow. Or perhaps my understanding is lacking?
There was a problem hiding this comment.
A merge wouldn't have to be pushed if it was done directly within the GitHub repo
There was a problem hiding this comment.
This does trigger on merge to main.
| - name: Restore dependencies | ||
| run: dotnet restore | ||
| working-directory: ./src | ||
|
|
||
| - name: Build |
There was a problem hiding this comment.
If we do run on every push/merge to master, can we reuse the artifact somehow rather than building from scratch?
There was a problem hiding this comment.
Good idea. Let's make this an investigation task for another day!
The changes in this PR are based loosely on the changes made to enable similar functionality in the speedometer repo: https://github.com/CompositionalIT/Feliz-ReactSpeedometer