Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#27 ensure custom props are of type IAgGridProp #28

Merged
merged 2 commits into from
Feb 16, 2024
Merged

#27 ensure custom props are of type IAgGridProp #28

merged 2 commits into from
Feb 16, 2024

Conversation

mattgallagher92
Copy link
Member

Closes #27.

Most of the props don't make sense with the current demo, so I haven't tested them. However, I was able to verify that AgGrid.suppressRowHoverHighlight true works.

@mattgallagher92 mattgallagher92 marked this pull request as ready for review February 16, 2024 14:51
@isaacabraham isaacabraham self-requested a review February 16, 2024 15:20
isaacabraham
isaacabraham approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@isaacabraham isaacabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isaacabraham isaacabraham merged commit 5c0e615 into main Feb 16, 2024
1 check passed
@isaacabraham isaacabraham deleted the 27-convert-react-props-to-ag-grid-props branch February 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theprash theprash theprash left review comments

@isaacabraham isaacabraham isaacabraham approved these changes

@martinbryant martinbryant Awaiting requested review from martinbryant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom props cannot be used as AgGrid props
3 participants
@mattgallagher92 @theprash @isaacabraham