-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update feliz #20
Update feliz #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Perhaps it'd be worth including a changelog (CHANGELOG.md?) to record that there is a breaking change, in case package users come wondering why the latest version of the package doesn't work for them?
I'm okay with that going into a separate PR (or even into an issue that you don't raise a PR for) if you're keen to get this out soon to unblock you.
Completely agree and so I think we should go with a v1 release as it is a breaking change. I have gone with a version compatibility chart on the readme and would be great to get your thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
As this package uses v1.x of Feliz and Fable React it has conflicts when trying to use in a project that uses Feliz v2.x. This PR will update all things Feliz, React and Fable