Skip to content

Commit

Permalink
Fixed code review remarks by @ninjarobot
Browse files Browse the repository at this point in the history
  • Loading branch information
xperiandri committed Oct 28, 2024
1 parent 84adfe5 commit 5fc4705
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/Farmer/Builders/Builders.Storage.fs
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,9 @@ type StorageAccountBuilder() =
Containers =
let containers =
names
|> List.ofSeq
|> List.map (fun name ->
|> Seq.map (fun name ->
((StorageResourceName.Create name).OkValue, access, immutabilityPolicies))
|> Seq.toList

state.Containers @ containers
}
Expand Down
8 changes: 4 additions & 4 deletions src/Farmer/Types.fs
Original file line number Diff line number Diff line change
Expand Up @@ -442,19 +442,19 @@ type FeatureFlagExtensions =

[<Extension>]
static member AsBoolean(featureFlag: FeatureFlag option) =
featureFlag |> Option.map (fun f -> f.AsBoolean) |> Option.toNullable
featureFlag |> Option.map _.AsBoolean |> Option.toNullable

[<Extension>]
static member AsInvertedBoolean(featureFlag: FeatureFlag option) =
featureFlag |> Option.map (fun f -> f.AsInvertedBoolean) |> Option.toNullable
featureFlag |> Option.map _.AsInvertedBoolean |> Option.toNullable

[<Extension>]
static member ArmValue(featureFlag: FeatureFlag option) =
featureFlag |> Option.map (fun f -> f.ArmValue) |> Option.toObj
featureFlag |> Option.map _.ArmValue |> Option.toObj

[<Extension>]
static member ArmInvertedValue(featureFlag: FeatureFlag option) =
featureFlag |> Option.map (fun f -> f.ArmInvertedValue) |> Option.toObj
featureFlag |> Option.map _.ArmInvertedValue |> Option.toObj

module FeatureFlag =
let ofBool enabled = if enabled then Enabled else Disabled
Expand Down

0 comments on commit 5fc4705

Please sign in to comment.