Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 Create AM, PM ScrollableSelctor #33

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Lee-Jun-Young
Copy link
Contributor

🎯 Related issue

🛠 Implementation

🔍️ summary

  • Create a ScrollableSelector for AM, PM in the timepicker.
  • Setting the valueList based on timePickerState.is24Hour.

📌 tasks

  • Create AM, PM ScrollableSelector.
  • When TimePickerState.is24Hour is true.
  • When TimePickerState.is24Hour is false.

- Change the data type from Int to String to enable the use of a meridiem ScrollerSelectable.
Copy link
Member

@lee989898 lee989898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ows3090 ows3090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create AM, PM ScrollableSelector
4 participants