-
Notifications
You must be signed in to change notification settings - Fork 756
Adding rules for /etc/cron.yearly directory configuration #14105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rules for /etc/cron.yearly directory configuration #14105
Conversation
|
Hi @Arden97. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -0,0 +1,44 @@ | |||
| documentation_complete: true | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for these extra new lines
| @@ -0,0 +1,44 @@ | |||
| documentation_complete: true | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for these extra new lines.
| @@ -0,0 +1,44 @@ | |||
| documentation_complete: true | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No needs for these new lines.
| status: automated | ||
| rules: | ||
| - file_groupowner_cron_yearly | ||
| - file_owner_cron_yearly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI issues:
Rule 'file_permissions_cron_yearly' must be in component 'cronie' because it's a member of 'cron_and_at' group.
Rule 'file_owner_cron_yearly' must be in component 'cronie' because it's a member of 'cron_and_at' group.
Rule 'file_groupowner_cron_yearly' must be in component 'cronie' because it's a member of 'cron_and_at' group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 6a54d25
|
@Mab879 are there any other changes required before this PR can be merged? If not, may I ask you to merge it so I can move the ticket to the 'Review' state?" |
Description:
This commit implements three new security hardening rules for the /etc/cron.yearly directory to complete the cron directory security coverage:
file_owner_cron_yearly: Verifies that/etc/cron.yearlyis owned by root (uid 0)file_groupowner_cron_yearly: Verifies that/etc/cron.yearlyhas root as group owner (gid 0)file_permissions_cron_yearly: Verifies that/etc/cron.yearlyhas permissions set to 0700 (rwx------)The implementation adds:
linux_os/guide/services/cron_and_at/pendingtoautomatedstatusRationale:
The RHEL 10 CIS Benchmark v1.0.1 requirement 2.4.1.7 require that writing access to
/etc/cron.yearlywas granted for non-privileged usersFixes # NEW RULE - 2.4.1.7 - Ensure access to /etc/cron.yearly is configured (Automated)