extend the bootc platform to cover both online and offline cases #14101
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine state it was discovered that there are two distint cases when we can be in the bootc environment. The first one is while the bootc image is actually hardened during its creation. This is manifested by presence of /ostree symlink. The second case is when we are in already booted bootc image. This was already covered before, but the file /run/ostree-booted is not present when building the image. Switching only to check for the /ostree symlink does not work as well, because in case of running bootc image, the /ostree is a directory, not a symlink. I think this covers both cases well and with reasonable accuracy.
Collaborator
Author
|
I have mistakengly pushed the branch into the main repo, not my fork. I hope it does not matter. |
|
@vojtapolasek: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jan-cerny
approved these changes
Nov 10, 2025
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
This fixes the failing /hardening/container/ tests on RHEL 9 for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
it was discovered that there are two distint cases when we can be in the bootc environment. The first one is while the bootc image is actually hardened during its creation. This is manifested by presence of /ostree symlink. The second case is when we are in already booted bootc image. This was already covered before, but the file /run/ostree-booted is not present when building the image. Switching only to check for the /ostree symlink does not work as well, because in case of running bootc image, the /ostree is a directory, not a symlink. I think this covers both cases well and with reasonable accuracy.
Review Hints:
Try hardening a bootc image and also anaconda rpmostree installation case.