Skip to content

CMP-3743: Remove unused Bearer token auth from metrics ServiceMonitor#1072

Open
Vincent056 wants to merge 1 commit intomasterfrom
metrics_token
Open

CMP-3743: Remove unused Bearer token auth from metrics ServiceMonitor#1072
Vincent056 wants to merge 1 commit intomasterfrom
metrics_token

Conversation

@Vincent056
Copy link

The metrics endpoint only uses TLS for security and does not validate Bearer tokens. Remove the dead code that configured token authorization and created the associated secret.

The metrics endpoint only uses TLS for security and does not validate
Bearer tokens. Remove the dead code that configured token authorization
and created the associated secret.
@openshift-ci-robot
Copy link
Collaborator

@Vincent056: This pull request references CMP-3743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The metrics endpoint only uses TLS for security and does not validate Bearer tokens. Remove the dead code that configured token authorization and created the associated secret.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1072-4aa68ebdc8598ec3d2128863d8703659d6d32608

@Vincent056
Copy link
Author

/retest
failures unrelated due to infra

@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

@Vincent056: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 4aa68eb link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants