Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no implicit conversion of Sprockets::Asset into String #2042 #2049

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

Davidiusdadi
Copy link

Fix #2042
Fix Compass/compass-rails#256

I am by no means familiar with the code.
I guess assume the issue has to do with Sprockets 3 support...

@timhaines
Copy link

Hey @Davidiusdadi, I'm encountering the same problem. Thanks for submitting the PR for this.

When I try your fork, I still get the same error, as it seems that compass is loading the functions from the compass-core gem. When I make the same change you have, to the compass-core gem, it works fine.

I'm not sure what the interplay is between the compass and compass-core gems. Are you familiar with them both?

@Davidiusdadi
Copy link
Author

Yes the bug (and the fix) are located in compass core.
To fix the problem in your project temporary put this in your gem file:

gem 'compass-core',  git: 'https://github.com/Davidiusdadi/compass.git',  branch: 'core'

I applied the fix to my fork and moved and made the core folder( https://github.com/Compass/compass/tree/stable/core ) the repo root in order to get bundler optain it.

@11mdlow
Copy link

11mdlow commented Feb 4, 2016

I am seeing this issue too. Your branch works for me @Davidiusdadi but it would be nice for this to be fixed and released as part of the core project.

@timhaines
Copy link

@11mdlow @Davidiusdadi I'd love to see a release too. It looks like the project's been abandoned by the creators/maintainers though. I asked @scottdavis on Twitter ( https://twitter.com/jetviper21/status/691004140709941250 ) and from the sounds of it, @chriseppstein is no longer interested in maintaining it.

@kayluhb
Copy link

kayluhb commented Feb 16, 2016

👍 thanks for the patch @Davidiusdadi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants