Icon fix on OSX 10.8 and other improvements#12
Open
mgibeau wants to merge 3 commits intoCompass:masterfrom
Open
Icon fix on OSX 10.8 and other improvements#12mgibeau wants to merge 3 commits intoCompass:masterfrom
mgibeau wants to merge 3 commits intoCompass:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The icon was not loading on OSX 10.8, not quite sure why, but a combination of the
file://protocol and a check for localhost in ruby_gntp breaks it (see: snaka/ruby_gntp@e84809d). It's a bit of a hack but I was able to avoid this by instantiating GNTP using127.0.0.1.While at it I made a few improvements: