Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hej,
I re-wrote the mzident reader and made it much faster, albeit maybe a bit less complete.
For now, I added the new reader alongside the old one. It does not use Pyteomics, but parses the structure more directly. Hence, it is less complete for complicated files, but should be good for most "normal" ones originating from a single search engine and contain only one search run.
I tested the conversion to TSV on some bigger files from MS-GF+ and Comet (2-20 GB) and the output was exactly identical to the files created by the original reader. But the conversion took only about a tenth of teh time (with equal memory consumption).
Would be great, if you could add this new reader, if you like it. As the conversion of the bigger files (like a combination of TimsTOF files and proteogenomics databases) otherwise takes days :)
Cheers,
Julian