Remove Colt dependency, replace with commons-math4-legacy#45
Merged
Remove Colt dependency, replace with commons-math4-legacy#45
Conversation
walterxie
added a commit
that referenced
this pull request
Mar 16, 2026
alexeid
added a commit
that referenced
this pull request
Mar 16, 2026
…ValueDecomposition Verifies eigenvalues/eigenvectors and singular values against known matrices (analytical) and rate matrices from transprob.R ground truth (4x4 equal freq, 4x4 extreme rates, 20x20 amino acid scale). Eigen tests verify A*V=V*D property; SVD tests verify A=U*S*V^T reconstruction, orthogonality, rank, and ordering. #45
alexeid
added a commit
that referenced
this pull request
Mar 16, 2026
…ValueDecomposition Verifies eigenvalues/eigenvectors and singular values against known matrices (analytical) and rate matrices from transprob.R ground truth (4x4 equal freq, 4x4 extreme rates, 20x20 amino acid scale). Eigen tests verify A*V=V*D property; SVD tests verify A=U*S*V^T reconstruction, orthogonality, rank, and ordering. #45
Replace vendored colt.jar with commons-math4-legacy (already a dependency) to unblock publishing beast3 to Maven Central. - RobustEigenDecomposition: accept/return double[][] instead of Colt types - RobustSingularValueDecomposition: same - ColtEigenSystem: use LUDecomposition from commons-math4 for matrix inverse - ComplexColtEigenSystem: adapt to new return types - KernelDensityEstimator2D: replace DoubleArrayList/Descriptive.quantile() - Mark beagle dependency as optional in both modules - Add Maven Central release job to CI (triggered by v* tags) - Remove colt.jar, colt module-info, and CI colt install/deploy steps Closes #44
…ValueDecomposition Verifies eigenvalues/eigenvectors and singular values against known matrices (analytical) and rate matrices from transprob.R ground truth (4x4 equal freq, 4x4 extreme rates, 20x20 amino acid scale). Eigen tests verify A*V=V*D property; SVD tests verify A=U*S*V^T reconstruction, orthogonality, rank, and ordering. #45
d1cf5f2 to
f285650
Compare
walterxie
approved these changes
Mar 16, 2026
alexeid
added a commit
that referenced
this pull request
Mar 18, 2026
Colt was replaced by commons-math4-legacy in PR #45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
Closes #44