Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Alignment #1174

Open
rbouckaert opened this issue Dec 12, 2024 · 0 comments
Open

Refactor Alignment #1174

rbouckaert opened this issue Dec 12, 2024 · 0 comments

Comments

@rbouckaert
Copy link
Member

rbouckaert commented Dec 12, 2024

Currently, the Alignment class does not allow editing of the actual alignment. Also, it does not allow continuous values. However, BEAUti relies on the Alignment class to define partitions, so it is fundamental to the user interface.

A workaround to get non-standard tree associated data into BEAUti is to derive from Aligment, e.g. beastclassic.evolution.alignment.AlignmentFromTraitMap, and suppress all kinds of options, like stateCount and methods.

A cleaner approach is to have a base class for Alignment -- say TreeData-- make BEAUti aware of that, and have the other classes currently deriving from Alignment derive from the TreeData class. The main work probably will be making BEAUti compatible with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant